Skip to content

Fix JS and TS coloring#142

Open
svipas wants to merge 9 commits into
nordtheme:developfrom
svipas:fix-js-ts-coloring
Open

Fix JS and TS coloring#142
svipas wants to merge 9 commits into
nordtheme:developfrom
svipas:fix-js-ts-coloring

Conversation

@svipas

@svipas svipas commented Jun 13, 2019

Copy link
Copy Markdown
  • JS & TS scopes and styles are consistent.
  • Their order of scopes are the same and they both contain the same amount of scopes needed. This means TS now have fixed interpolated string templates, JS now contains color for class initialization and so on.
  • Remove bold font style from Entity Other Inherited Class.
  • Add JSX inner text scope for TS and JS.
  • Add Node.js global variables support for JS and TS.
  • Add missing meta.brace.round () and meta.brace.square [] scopes.

Fixes #120

@svipas svipas requested a review from svengreb as a code owner June 13, 2019 08:20
@svipas

svipas commented Oct 4, 2019

Copy link
Copy Markdown
Author

Hi @arcticicestudio, there's still an issue with JS & TS color inconsistencies, if you want I can fix conflicts of this PR.

@svengreb

Copy link
Copy Markdown
Member

@svipas Thanks again for your contribution 🚀
The pull request has been added for triage and the review will be planned for the next iterations!

@svipas

svipas commented Jul 17, 2023

Copy link
Copy Markdown
Author

@svengreb Thanks for the best theme ever! This PR is pretty old and might require some work to do before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: triage

Development

Successfully merging this pull request may close these issues.

TS and JS inconsistencies

3 participants